Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(standalone): add monitoring configuration files #16594

Merged
merged 2 commits into from
May 10, 2024

Conversation

kwannoel
Copy link
Contributor

@kwannoel kwannoel commented May 6, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

As per title. Basically these can be used by standalone mode users to run grafana, prometheus. Documentation on using these can be found here: https://github.com/risingwavelabs/risingwave-docs/pull/2125

These files should not change much (if at all), they are grafana.ini and prometheus.yaml which just set various host addresses.

For dashboard json specifications, we can just let the user manually import them via grafana's interface, just need to import from /grafana.

We can generate these artifacts via risedev down the road, once we integrate single_node into risedev. Tracked here: #16601.

Can't reuse docker artifacts for these, because they use service name as the addresses instead.

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@kwannoel kwannoel requested review from fuyufjh, BugenZhao and st1page May 6, 2024 13:38
@kwannoel
Copy link
Contributor Author

Bump, let's make sure the documentation gets into 1.9

@kwannoel
Copy link
Contributor Author

cc @fuyufjh @st1page

Copy link
Member

@fuyufjh fuyufjh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kwannoel kwannoel added this pull request to the merge queue May 10, 2024
Merged via the queue into main with commit c52cb9c May 10, 2024
37 of 38 checks passed
@kwannoel kwannoel deleted the kwannoel/standalone-monitoring branch May 10, 2024 03:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants